Restructure CI workflow + fixes #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 19, 2021 16:31
The formula now uses a URL and SHA of the .zip package.
- Upload Windows packages as GHA artifacts so that they can be made part of the GH release (#1750). - Upload Bintray packages in a single job.
Part of #1750 Since we're merging the MSI package with the other built artifacts it's simpler to generate the checksum file right before creating the GH release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1750
This restructures the GitHub Actions CI workflow to upload the signed MSI package to the GH release, and also fixes the checksum file generation (it no longer includes itself, d'oh!) and the
brew bump-formula-prcommand (🤞 ). Though thisbrewchange is untested, I just confirmed that the command is correct.You can see a test release here.